search

martanne / dvtm

dvtm brings the concept of tiling window management, popularized by X11-window managers like dwm to the console. As a console window manager it tries to make it easy to work with multiple console based programs.
MIT License
857 stars 106 forks source link

Correct type of loop variable to avoid overflow #82

Closed phillid closed 6 years ago

phillid commented 6 years ago

When COLOR_PAIRS is >= 32768, a short loop counter cannot cannot compare larger than COLOR_PAIRS, resulting in an infinite loop.

This was discovered as a freeze bug during testing where COLOR_PAIRS was 65535.

Additionally, at least on my system, the manpage for COLOR_PAIRS says it is declared as int.

martanne commented 6 years ago

Thanks, superseded by #85.