search

martanne / dvtm

dvtm brings the concept of tiling window management, popularized by X11-window managers like dwm to the console. As a console window manager it tries to make it easy to work with multiple console based programs.
MIT License
857 stars 106 forks source link

COLOR_PAIRS can be greater than max short #85

Closed shua closed 6 years ago

shua commented 6 years ago

this is causing dvtm to hang on startup

changes some types from short to int, but it might make more sense to clamp COLOR_PAIRS down to some maximum, maybe output an error if it's too big.

shua commented 6 years ago

this fixes #83 and #84 for me, can anyone else confirm?

shua commented 6 years ago

I noticed a similar PR for vis, I may adopt the changes there: https://github.com/martanne/vis/pull/672

shua commented 6 years ago

I believe this also supersedes #82

Larivact commented 6 years ago

Thank you, this fixes #83 and #84 for me.

shua commented 6 years ago

cc @martanne Please review; if there's any changes you'd like, let me know.

This fixes #83 which makes dvtm unusable, and #84.

martanne commented 6 years ago

Thanks for looking into this and sorry for the unresponsiveness. I hope to have a bit more time for dvtm in the future.