search

martanne / vis

A vi-like editor based on Plan 9's structural regular expressions
Other
4.25k stars 258 forks source link

Re-enabled tre by #including <stddef.h>. #1000

Closed somercet closed 2 years ago

somercet commented 2 years ago

I noticed libtre.so.5 was not linked to the vis binary; this fixes the test code in ./configure. I think this was caused by compilation on Void Linux's musl libc arch.

Love,

p

mcepl commented 2 years ago

Is this just an musl issue? With my Linux I seem to have libtre.so.5 linked just fine:

stitny~$ ldd /usr/bin/vis|grep tre
    libtre.so.5 => /lib64/libtre.so.5 (0x00007f21845ae000)
stitny~$
somercet commented 2 years ago

I think it is just a musl (or gcc behavior under musl) thing. But it won't break normal builds, it's just auto-included on glibc arches.

ninewise commented 2 years ago

Could verify the issue (and fix) on Void. Merging. Thanks for the contribution!

somercet commented 2 years ago

Your welcome!