search

martanne / vis

A vi-like editor based on Plan 9's structural regular expressions
Other
4.25k stars 258 forks source link

Add support for the Hare language file type #1011

Closed qiu-x closed 2 years ago

qiu-x commented 2 years ago

https://harelang.org

MuhammedZakir commented 2 years ago

Lexers are fetched from upstream: https://github.com/orbitalquark/scintillua/. You should open the PR there.

qiu-x commented 2 years ago

I see, thanks for the info. And what about the changes in lua/plugins/filetype.lua? I think that those are still necessary here.

jgarte commented 2 years ago

Lexers are fetched from upstream: https://github.com/orbitalquark/scintillua/. You should open the PR there.

Would it be possible to install the lexers from orbitalquark instead of vendoring them in?

MuhammedZakir commented 2 years ago

I see, thanks for the info.

You're welcome!

And what about the changes in lua/plugins/filetype.lua? I think that those are still necessary here.

Changes to that should be made here.

Lexers are fetched from upstream: https://github.com/orbitalquark/scintillua/. You should open the PR there.

Would it be possible to install the lexers from orbitalquark instead of vendoring them in?

I think it was done this way for bundling everything together, which makes installing easy. Another important advantage is that, if the upstream made any backward-incompatible changes, you can prevent vis from breaking, which is not possible if lexers are directly fetched from upstream.

ninewise commented 2 years ago

Applied in eb96e0ce8143804f5a7a37eb76a4b86d8871dd76