search

martanne / vis

A vi-like editor based on Plan 9's structural regular expressions
Other
4.19k stars 259 forks source link

build: update alpine in docker build to version 3.17 #1054

Closed eworm-de closed 1 year ago

eworm-de commented 1 year ago

This requires one extra package, as static liblzma (liblzma.a) was moved to xz-static.

mcepl commented 1 year ago

This looks very trivial, please, ninewise, merge.

mcepl commented 1 year ago

Wouldn’t it be better to maintain the Dockerfile in a special repo, please? This makes unnecessary churn because of technology with questionable value to most users (how many users of vis use it via Docker?) and putting unnecessary pressure on already overworked maintainers. Besides, the image is not even published on any public hub, so what it is good for anybody?

@ninewise, @martanne ?

eworm-de commented 1 year ago

This is really trivial... Just pressing the merge button is all we need. 😜

But seriously... Mostly this is just bumping the version. If build breaks I will handle this - which makes the above apply.

ninewise commented 1 year ago

Applied on good faith: I'm not willing to install docker just to test this.

I do agree with mcepl that it's a bit weird to have a dockerfile for vis in the main repository.

eworm-de commented 1 year ago

Thanks!

Well, it goes hand in hand with vis-single.c and more bits. No idea how easy it is to put all needed code in a separate repository.