search

martanne / vis

A vi-like editor based on Plan 9's structural regular expressions
Other
4.19k stars 259 forks source link

Revert "fix bug where visual-line selections after view were consider… #1085

Closed erf closed 1 year ago

erf commented 1 year ago

…ed visible"

This reverts commit c22b2c2937d9dd65d0609e57f948f08da7f5c5ea.

Fixes issue #1084

mcepl commented 1 year ago

Merged into https://git.sr.ht/~mcepl/vis/tree and it seems to be working.

rnpnr commented 1 year ago

Just to reiterate the correct fix seems to be #1087 which maintains the fix for #1074 and fixes the issues introduced by c22b2c2. I don't think reverting c22b2c2 is correct.

mcepl commented 1 year ago

Just to reiterate the correct fix seems to be #1087 which maintains the fix for #1074 and fixes the issues introduced by c22b2c2. I don't think reverting c22b2c2 is correct.

You are completely right, and this particular PR should be closed and abandoned.