martanne / vis

A vi-like editor based on Plan 9's structural regular expressions
Other
4.19k stars 259 forks source link

vis.1: list equivalent key bindings on the same line #1097

Closed rnpnr closed 1 year ago

rnpnr commented 1 year ago

it is hard to tell which line <C-u> and <C-d> are supposed to belong to in the current version.

Note that if keeping the pairs on separate lines is preferred I can update the patch to say same as xxx instead.

see #1033

mcepl commented 1 year ago

I really don’t which version is better.

Old version:

screenshot-2023-05-03_17-05-1683129313

New version:

screenshot-2023-05-03_17-05-1683129337

Both of them look strange.

rnpnr commented 1 year ago

Here are two alternatives: image or image Are either of them better?

mcepl commented 1 year ago

Are either of them better?

I really don't like the second one. So I think it is between this PR and the current state.

tosch42 commented 1 year ago

The current state is very confusing. I'd expect C-p and C-u to do the same thing, since one is reading from top to bottom. I prefer the new version because it supports the natural reading flow.

ninewise commented 1 year ago

Applied in e6fc48dea1909e916c13ac58a4ff64a379ef30f0