search

martanne / vis

A vi-like editor based on Plan 9's structural regular expressions
Other
4.19k stars 259 forks source link

Add csproj and psm1 extensions to filetype #1131

Closed milhnl closed 9 months ago

milhnl commented 9 months ago

Hey all, just a small change, so not much to comment.

milhnl commented 9 months ago

I'm ok with not adding it, but I (and others working with dotnet projects) do need to edit it by hand (and not just small edits, it's just initially autogenerated), so if that makes you reconsider, great. It's also not vscode specific at all. The modification for my visrc you propose is already in there, but yours is more efficient. Thanks :)

mcepl commented 9 months ago

On Mon Sep 18, 2023 at 7:16 PM CEST, Randy Palamar wrote:

I'll say yes to the .psm1 type but no to the .csproj type. The latter seems to be auto-generated and mostly used by vscode. I don't really think supporting every random auto-generated file from other text editors makes any sense for vis.

Just +1 for this decision from me.

-- https://matej.ceplovi.cz/blog/, Jabber: @.*** GPG Finger: 3C76 A027 CA45 AD70 98B5 BC1D 7920 5802 880B C9D8

I’ve never seen God worried yet. -- Wm. Paul Young

milhnl commented 9 months ago

Sure. But the reasoning is still incorrect.

rnpnr commented 9 months ago

I just pushed 7367ea8 which should also cover your csproj file.

Thanks for the patch!

milhnl commented 9 months ago

Smart. Thanks. file says it's text/plain on my system but that's not vis' problem.