search

martanne / vis

A vi-like editor based on Plan 9's structural regular expressions
Other
4.21k stars 258 forks source link

Add support for themeable colors in (default) theme(s) #917

Closed moesasji closed 3 years ago

moesasji commented 3 years ago

The use of themeable colors can give surprising behavior as some themes have a colors table defined and exported - solarized.lua:23, but the default one doesn't. (And even solarized.lua doesn't currently have the black color for the hr rule used in the markdown lexer.)

Suggested fix in the pull-request that triggered this issue: add a colors table to all the themes, so vis could use unmodified lexers from Scintillua.

Originally posted by @lepotic in https://github.com/martanne/vis/issues/916#issuecomment-749124065

martanne commented 3 years ago

I think this is already fixed by a commit included in the scintillua branch? If not then feel free to re-open the issue with a more specific description of the problem.