search

martanne / vis

A vi-like editor based on Plan 9's structural regular expressions
Other
4.21k stars 258 forks source link

Improve word and file name completion with non-ASCII characters #946

Closed Shugyousha closed 11 months ago

Shugyousha commented 3 years ago

These two commits fix this issue https://github.com/martanne/vis/issues/941.

Note that vis-menu is still not handling Unicode correctly (it's still not differentiating properly between bytes and "grapheme clusters", i.e. printable glyph-combinations, when calculating lengths). With these changes we are at least able to have a working support for non-ASCII characters in the simple case.

rnpnr commented 11 months ago

There are definitely still some issues with handling of non-ASCII characters after applying this but overall I think this improves the situation.

I'm thinking of applying it apart from the call to die(). Any objections?

Shugyousha commented 11 months ago

On August 10, 2023 5:59:08 PM GMT+02:00, Randy Palamar @.***> wrote:

There are definitely still some issues with handling of non-ASCII characters after applying this but overall I think this improves the situation.

I'm thinking of applying it apart from the call to die(). Any objections?

I'm also for removing the "die()" before applying. Thanks for picking up this PR!

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

rnpnr commented 11 months ago

Applied, thanks for the patch!