Simpler and more flexible insert completion

martanne / vis

A vi-like editor based on Plan 9's structural regular expressions

Other

4.2k stars 258 forks source link

Simpler and more flexible insert completion #959

Closed jpaulogg closed 2 years ago

jpaulogg commented 3 years ago

This PR improves vis insert completion in the following ways:

allow the shell to expand filename prefixes. This way, tilda and environment variables can be used properly;
simpler rewriting of vis-completion;
escape spaces occurrences in vis-open output;
allow to complete text objects other than short words (for example, functions names in an external file).

More specific details can be found in the commit messages.

PS: I wrote a plugin that benefits from these changes.

mcepl commented 1 year ago

@jpaulogg Why did you close this PR? It seems to make sense?

jpaulogg commented 1 year ago

@jpaulogg Why did you close this PR? It seems to make sense?

I'm not a programmer and i'm not very familiar with git and github, so I made a little mess with the forced commits. I was thinking about opening a new PR, including some simplifications to the vis-open script.

mcepl commented 1 year ago

Merged into https://git.sr.ht/~mcepl/vis/tree and after brief testing, it seems to be working.