Parisra commented 1 year ago

Hi @martavp and @TimToernes , This pull request includes changes that solve some of the current issues such as the filtering method and adding variables like 'added capacity' (I will also answer each issue separately). I've added many variables, and the next step is to use the Config file to filter which variables should be calculated for each network. Currently the script writes all the variables to the excel, so even if for example 'industry' is not in the network, all variables related to it will be '0' in the output table, which could be misleading. Other comments:

The variables definitely need some checking. I will try to do this myself and would appreciate any feedback on wether some calculations/numbers/units don't seem correct.
I am still trying to find an efficient way to add 'Cumulative capacity' variables to the script.
There is some overlap between 'carbon intensity' and 'carbon emissions'. Currently I have only added 'Carbon intensity' since the emissions are divided between specific gases (CO2, Nox, etc.), but there is no variable for equivalent carbon emissions, which I believe is closest to the number calculated by PyPSA.
'Agriculture' related variables are not yet added.
'Primary energy' is not included yet.

martavp commented 1 year ago

I added (in the menu on the left -Development) the number of some of the issues that will be closed when this PR is accepted. Could you check if that is correct and add other issues if relevant?

Parisra commented 1 year ago

26

martavp commented 1 year ago

If this issue is closed by this PR, then you can add it to the right, just below "Successfully merging this pull request may close these issues."

martavp commented 1 year ago

I think this is ready to merge, as soon as you clarify what you did with the storage capacities For next PR and commits I suggest you use more explanatory names. For example "additional fixes" is difficult to understand, you can all it "fixed definition for storage capacities". Also, split the commits into small commits. For example, "fixed definition of storage capacities", "add comments on solar thermal", "implement MW2GW" . This makes it much easier to review.

For the PR also use descriptive names "Ipcc patch 3" is not giving any information. This can be called "fixing storage capacities and MW2GW factor"

Parisra commented 1 year ago

This pull request is ready to be merged. I will be doing another PR afterwards for updating the documentation.

martavp / pypsa-eur-sec-to-ipcc

Ipcc patch3 #33

26