search

martenjacobs / py-otgw-mqtt

Python OTGW MQTT bridge
MIT License
9 stars 16 forks source link

Tcp #6

Closed wouterbaake closed 3 years ago

wouterbaake commented 5 years ago

I tried using your TCP branch to communicate with OTGW that is hooked up to an ESP which runs ESPlink. Under linux I can connect to the ESPlink via nc or telnet, but your TCP branch did not receive any updates. While trying to get it to work I fixed some small issues. After a while I tried implementing an extra subclass to opentherm to use telnetlib. This works fine with my ESPlink.

martenjacobs commented 5 years ago

Hi Wouter, I'm sorry for taking so long to get back to you. I was a bit taken aback by the number of commits in your PR, but after taking a look it seems the changes are quite concise. I'm also seeing a change outside of the scope of this PR, adding a subscription topic namespace. This seems like a good idea to me. However, I'm seeing some things I'd like to see changed, so I've added comments to the changes.