search

marthinal / ngDrupal

Angular module for Drupal 8 Rest Services.
12 stars 2 forks source link

Combine with angular-drupal? #1

Open kentr opened 8 years ago

kentr commented 8 years ago

@marthinal, I would be great to see this project and angular-drupal combined. I like it that you're using restangular.

clemens-tolboom commented 8 years ago

@kentr interesting project https://github.com/easystreet3/angular-drupal

This project https://github.com/marthinal/ngDrupal is small D8 login.

My project https://github.com/clemens-tolboom/drupal-8-rest-angularjs does the "'whole' she-bang" in an ugly way. So I'm interested in the others :)

marthinal commented 8 years ago

@kentr @clemens-tolboom Hi!

Well, basically the idea is to create a really simple angular module for CRUD operations + Login/logout(cookie sessions) + Register users(anonymous) + Get resources and using the D8 REST module.

I'm using ngDrupal on a small project and I need to update the current repo, add examples, etc... I would like to do it asap. I have many new changes and I would like to review it correctly before update.

So we have an EntityService( to create entities), an AuthService, RegisterService, GetResourcesService.

Anyway and to be honest we need to work on multiple task on Drupal Core. For example cookie sessions and register new users services need work.

kentr commented 8 years ago

@marthinal That sounds great. I don't speak for the angular-drupal authors, but as a Drupal developer and software developer I see a lot of advantages to working together instead of having multiple projects with a lot of overlap.

angular-drupal 8.x-1.x is currently using the jDrupal library for all the REST calls, which includes entity CRUD, auth and other things. Perhaps there is a way to team up on the pieces which overlap.

I look forward to seeing your updates.

marthinal commented 8 years ago

@kentr Sure, I understand what you mean. But I think angular-drupal and ngDrupal are different. ngDrupal is an Angular module where we use angular services (probably more angular way). angular-drupal uses jDrupal and I like the idea but are different ways. Anyway, I think Tyler is doing a great job and contributing a lot to the Drupal project :)

kentr commented 8 years ago

They are different in implementation, but not so different in purpose & planned functionality. They both are providing Drupal 8 REST clients as Angular modules / services.

angular-drupal's use of jDrupal was my doing, and in my mind it is a temporary, suboptimal solution. I needed a D8 REST client library for an Ionic project, and jDrupal looked like the best game in town at the time. So I converted angular-drupal into a wrapper for jDrupal, knowing that it would be better to eventually make angular-drupal more "Angular like".

All I'm suggesting is collaboration toward creating a great D8 REST client library for Angular, however possible.

If ngDrupal is stable and covers the same ground, I'd really like to see your updates to consider it for my project.

marthinal commented 8 years ago

@kentr Sure. You can send PRs but I think you should wait because I would like to finish the basic architecture (a few services... Registration and others). Then we can refactor and would be great to cover with tests.

We need to fix some D8 core issues(features and bugs) that need work.

I would like to add an example about how to implement the infinite scroll as well.

Keep in contact!