chore: limesurvey upgrades

martialblog / helm-charts

Helm Charts

MIT License

4 stars 13 forks source link

chore: limesurvey upgrades #100

Closed Karitham closed 1 month ago

Karitham commented 3 months ago

make 6-apache the default tag (I've read the release notes and apart from themes there should be no breaking changes)

I will be running my own branch in production for the time being, but am hopeful we can figure out a way to merge this and keep this repository a central place for limesurvey.

martialblog commented 3 months ago

Hi, thanks for the PR. Could you update the tests also? Probably just updating the input values for the image name should do it.

Karitham commented 3 months ago

First commit (https://github.com/martialblog/helm-charts/pull/100/commits/60ddf3dbaf55c9bb38b05b28330423c5467cfe03) fixes unit-test failures specific to the runner failures, second commit (https://github.com/martialblog/helm-charts/pull/100/commits/e39281388964a11beb73300dca8a2abf049c9f77) fixes the rest that also fail for me locally (using latest helm-unittest). Hopefully the tests pass but if they don't I can revert last commit and fix all the failing tests and upgrade the action in a later PR.

Karitham commented 3 months ago

Apparently this new syntax broke it, so I reverted the commit. Once this is ok I'll make another PR to upgrade helm-unittest

Karitham commented 2 months ago

Unfortunate; https://github.com/martialblog/helm-charts/actions/runs/9894265988/job/27331360082 same problems.

Karitham commented 1 month ago

rewrote the PR to make it simpler to read and review. Just bumping ls to 6.x