search

martialblog / helm-charts

Helm Charts
MIT License
4 stars 13 forks source link

Fix typo in container registry domain #77

Closed p- closed 1 year ago

p- commented 1 year ago

Hi martialblog/helm-charts!

This is not an automatic, 🤖-generated PR, as you can check in my GitHub profile, I work for GitHub and I am part of the GitHub Security Lab.

While performing a code search for container registry domains we noticed that this repo contains a misspelled domain name.

If a malicious actor were in control of that misspelled domain, they could potentially perform an attack on the software supply chain of this project and/or steal the credentials used to connect to the container registry (depending on how the misspelled domain name of the container registry is used - In some cases it's only a matter of wrongly tagged container images) Please verify the changes made with this PR and check your documentation for similar typos.

martialblog commented 1 year ago

Well hello there @p- thanks for the PR! Just yesterday I read the GitHub Blog article about the new code search and I assume this is one of the new super powers you acquired... grep -r gchr *all-repos* :safety_vest:

Luckily for me this was only in a test file. Nonetheless, Dankeschön.

p- commented 1 year ago

Luckily for me this was only in a test file.

I assumed as much, but you can never know for sure. Gern geschehen! 😉