martialblog / helm-charts

Helm Charts
MIT License
4 stars 13 forks source link

Liveness and readiness probes not configurable #84

Open Bloodiko opened 1 year ago

Bloodiko commented 1 year ago

In our case, the default Timeout for liveness and readiness are 1s,

This sometimes set the Ready state to 0/1 as the pod was too slow to answer in a few cases. Basically forcing the pod to restart.

Adjusting the Probe timeouts within the values chart may be helpful.

livenessProbe:
            failureThreshold: 3
            httpGet:
              path: /
              port: http
            periodSeconds: 10
            successThreshold: 1
            timeoutSeconds: 5
readinessProbe:
            failureThreshold: 3
            httpGet:
              path: /
              port: http
            periodSeconds: 10
            successThreshold: 1
            timeoutSeconds: 5

we just hardcoded the timout manually in the deployment.yaml currently, but adjusting it within the values yaml should help.

martialblog commented 1 year ago

Hi, yeah sure. That makes sense. Do you want to open a PR for that?

Bloodiko commented 1 year ago

i could try, but i'm not that familiar with the helm chart syntax.

i just rolled it out via adding default values to the values.yaml hoping it would work :D I'll see when i get home later.