marticliment / UniGetUI

UniGetUI: The Graphical Interface for your package managers. Could be terribly described as a package manager manager to manage your package managers
https://www.marticliment.com/unigetui/
MIT License
10.32k stars 338 forks source link

[BUG] Scoop manifest link broken #1234

Closed ppvnf closed 4 months ago

ppvnf commented 11 months ago

Please confirm these before moving forward

Describe your issue

I have encountered a few situations when this seems to be the case:

  1. Packages from https://github.com/Calinou/scoop-games (scoop bucket add games)
  2. Packages from custom buckets (ex: https://github.com/Zliced13/MyScoop)
  3. Packages from nirsoft (https://github.com/ScoopInstaller/Nirsoft/blob/master/bucket/shmnview.json) This seems to be an exception as the local json and the github one have different names shellmenuview.json.txt
  4. https://github.com/marticliment/WingetUI/issues/1234#issuecomment-1696337199

Steps to reproduce the issue

No response

WingetUI Log

n/a

Package Managers Logs

n/a

Relevant information

No response

Screenshots and videos

No response

ppvnf commented 10 months ago
Screenshot 2023-08-28 220810

non portable has problem in manifest and source

marticliment commented 10 months ago

See #1325

marticliment commented 10 months ago

After some changes to the scoop package manager this appears to work now. Can you please retest on the latest commit?

ppvnf commented 10 months ago

I am unable to click it

Screenshot 2023-09-03 100402 Screenshot 2023-09-03 100017
marticliment commented 10 months ago

image For me, the nirsoft one works fine.

ppvnf commented 10 months ago

The problem might be that I am running the .py file directly instead of the binary because I am getting this error when trying to build it

Screenshot 2023-09-03 130326 Screenshot 2023-09-03 130504
marticliment commented 10 months ago

This issue is caused due to Python 3.11.4+ is not compatible with PyInstaller 5.9.0.

Either downgrade to Py3.11.3 or change requirements.txt to use a newer PyInstaller version (may trigger virus issues)

ppvnf commented 10 months ago

I managed to build, but the manifest links are still incomplete

Screenshot 2023-09-03 234123

also for some reason I am getting a bunch of chocolatey packages wrongly appearing as installed

Screenshot 2023-09-03 234157
marticliment commented 10 months ago

Can you please attach your logs?

ppvnf commented 10 months ago

log package.txt log wingetui.txt

ppvnf commented 9 months ago

also for some reason I am getting a bunch of chocolatey packages wrongly appearing as installed

should I open a new issue for this?

marticliment commented 9 months ago

Yes, please

ppvnf commented 9 months ago

this issue also, couldn't it be because I am using latest Python/Pyinstaller?

ppvnf commented 9 months ago

I have installed the latest beta and the bug remains

marticliment commented 9 months ago

this issue also, couldn't it be because I am using latest Python/Pyinstaller?

Latest beta does use non-latest, so this is not the issue

ppvnf commented 9 months ago

Maybe related. does it look the same to you?

Screenshot 2023-09-19 182953
marticliment commented 9 months ago

no, it should not look like this

marticliment commented 9 months ago

please run scoop bucket list on a cmd window

ppvnf commented 9 months ago
Screenshot 2023-09-19 212258
ppvnf commented 9 months ago

Replacing the ~ with the url beginning should work, right?

ppvnf commented 9 months ago

I realized I uninstalled git, reinstalling it fixed the problem with the tilde.

marticliment commented 9 months ago

Replacing the ~ with the url beginning should work, right?

Custom buckets won't work then.

Since this would not happen under normal circumstances (scoop requires git to work, and git is installed alongside scoop), I will close this issue

ppvnf commented 9 months ago

about the original issue, I have tested it and the only case it doesn't work (broken link) is for this bucket (if the package is global) MyScoop https://github.com/Zliced13/MyScoop

Screenshot 2023-09-19 214739
marticliment commented 7 months ago

It does work now for me, please test the latest code

ppvnf commented 7 months ago

In in the discovery section it works, but on the installed section I have the same problem as in https://github.com/marticliment/WingetUI/issues/1234#issuecomment-1726426797