[BUG] Error on Install after selecting language

erab76 commented 4 months ago

Please confirm these before moving forward

[X] I have searched for my issue and have not found a work-in-progress/duplicate/resolved issue.
[X] I have tested that this issue has not been fixed in the latest (beta or stable) release.
[X] I have checked the FAQ section for solutions.
[X] This issue is about a bug (if it is not, please use the correct template).

UniGetUI Version

3.1.0

Windows version, edition, and architecture

Windows 11 Home 23H2 Build 22631.3880

Describe your issue

When installing UniGetUi version 3.0.1, after selecting the language, the installation crashes with the following error message::

Screenshot 2024-07-14 120221

Disabling the antivirus doesn't solve the problem

Steps to reproduce the issue

No response

UniGetUI Log

No UniGetUi Logs available

Package Managers Logs

No Package Manager Logs are available

Relevant information

No response

Screenshots and videos

No response

marticliment commented 4 months ago

This looks like a windows error. Please try running a health check: https://www.windowscentral.com/how-use-dism-command-line-utility-repair-windows-10-image

erab76 commented 4 months ago

Checkhed with both DISM and SFC, no errors found. The problem is only on UniGetUI 3.1.0, the WinGetUI 3.0.2 installation works fine.

marticliment commented 4 months ago

I will investigate, but I am afraid this is not directly caused by UniGetUI

erab76 commented 4 months ago

I think the problem is related to the installer and not the app. Could it be it is trying to uninstall the previous version even if not present?

marticliment commented 4 months ago

No, the installer does not call the uninstaller, it just overwrites the installation

erab76 commented 4 months ago

I tried launching the installer from powershell with the option /LOG

This is the result:

2024-07-15 23:21:51.016 Log opened. (Time zone: UTC+02:00) 2024-07-15 23:21:51.017 Setup version: Inno Setup version 6.2.2 2024-07-15 23:21:51.017 Original Setup EXE: C:\Users\bare7\Downloads\UniGetUI.Installer.exe 2024-07-15 23:21:51.017 Setup command line: /SL5="$200550,52105540,1228800,C:\Users\bare7\Downloads\UniGetUI.Installer.exe" /LOG=C:\Users\bare7\Downloads\log.txt 2024-07-15 23:21:51.017 Windows version: 10.0.22631 (NT platform: Yes) 2024-07-15 23:21:51.018 64-bit Windows: Yes 2024-07-15 23:21:51.018 Processor architecture: x64 2024-07-15 23:21:51.018 User privileges: Administrative 2024-07-15 23:21:51.028 Administrative install mode: Yes 2024-07-15 23:21:51.028 Install mode root key: HKEY_LOCAL_MACHINE 2024-07-15 23:21:51.029 64-bit install mode: No 2024-07-15 23:21:53.105 Created temporary directory: C:\Users\bare7\AppData\Local\Temp\is-SJCUF.tmp 2024-07-15 23:21:53.106 -- DLL function import -- 2024-07-15 23:21:53.106 Function name: ExitProcess 2024-07-15 23:21:53.106 DLL name: kernel32.dll 2024-07-15 23:21:53.106 Dest DLL name: kernel32.dll 2024-07-15 23:21:53.106 Importing the DLL function. 2024-07-15 23:21:53.106 Successfully imported the DLL function. Delay loaded? No 2024-07-15 23:21:53.107 InitializeSetup raised an exception (fatal). 2024-07-15 23:21:53.107 Exception message: 2024-07-15 23:21:53.107 Message box (OK): Runtime error (at 40:328):

                      This action is only valid for products that are currently installed.

2024-07-15 23:21:54.267 User chose OK. 2024-07-15 23:21:54.268 Deinitializing Setup. 2024-07-15 23:21:54.269 Log closed.

Seems a problem related to the dependencies.

Both Webiew2 and VisualC++ 2015-2022 are installed. I will try investigating the IsMsiProductInstalled function of the installer.

erab76 commented 4 months ago

Compiling the WingetUI.iss with Inno Setup 6 the error appears in CodeDependencies.iss when checking for Visual C

procedure Dependency_AddVC2015To2022; begin // https://docs.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist _if not IsMsiProductInstalled(DependencyString('{36F68A90-239C-34DF-B58C-64B30153CE35}', '{36F68A90-239C-34DF-B58C-64B30153CE35}'), PackVersionComponents(14, 30, 30704, 0)) then begin Dependency_Add('vcredist2022' + Dependency_ArchSuffix + '.exe', '/passive /norestart', 'Visual C++ 2015-2022 Redistributable (x64)' + Dependency_ArchTitle, Dependency_String('https://aka.ms/vs/17/release/vc_redist.x64.exe', 'https://aka.ms/vs/17/release/vc_redist.x64.exe'), '', False, False); end; end;

marticliment commented 4 months ago

Will add an option to skip installation of vcredist

marticliment commented 4 months ago

Closing as duplicate

CodeAru commented 3 months ago

Hello I have the same issue at my end. But my OS is Windows 10.

Is there a dependency I am missing?

marticliment / UniGetUI