[Feature]: GUI for bible installation

martijnlentink / propresenter-custom-bibles

Tutorial to import custom Bibles in ProPresenter

28 stars 11 forks source link

[Feature]: GUI for bible installation #26

Open FranzMartyn opened 1 month ago

FranzMartyn commented 1 month ago

Right now, the only way to install bibles is via a terminal. I think creating a seperate GUI application (and maybe even a CLI option for bible_import.py to open that application) would be very beneficial for people who may be unfamiliar with using a terminal.

The GUI doesn't have to be complicated, maybe just Labels and Comboboxes using tkinter or even ThorPy.

FranzMartyn commented 1 month ago

Here is an early draft:

https://github.com/user-attachments/assets/259d13a8-367f-4256-a686-21840339aeed

martijnlentink commented 1 month ago

Hi @FranzMartyn,

Thanks for taking the time to go beyond and investing some time in making a graphical interface. I think this is very useful and can help quite some people. I do have a few remarks though.

If we want to go with a graphical interface we should not abide by the 'flow' in which the command line script works. I think that will be far from optimal
It would be nice to list your installed bibles and be able to manage them from the interface (e.g. creating/deleting/overwriting etc)
Another thought I have; wouldn't it be more beneficial to convert the script into a Javascript/WASM equivalent which enables it to be run in a browser. If we could manage to do that we could create a HTML interface and it will run in the browser without downloading an executable or running Python.

Anyways. Happy to see you working on this. Feel free to create a PR so we can track your progress.

Martijn

FranzMartyn commented 1 month ago

Hello Martijn,

I actually wanted to create another issue about being able to remove bibles but I guess don't need to that anymore. I would suggest to maybe use flask and HTML instead of WASM (mostly because I have no experience with WASM).

martijnlentink commented 1 month ago

Thank you for your suggestion. And of course, a backend solution can be created with minimal effort, but I want to refrain from providing such a service for the reason that RenewedVision nor YouVersion has given us permission to retrieve, store and distribute bible translations. YouVersion has written a complete FAQ about copyright and licensing of bibles. If you use a bible you must have permission of the license holder!

Therefore I do not want to host a service which will violate this. That is also the reason I did not just provided all bibles as .rvbibles to download. If we want to provide an interface to the user it must be running entirely on their machine which will be the responsibility of the user to get the license holder permission to use it.

FranzMartyn commented 1 month ago

I have thought about the server running on the user's machine and the user being able to access it through localhost.

martijnlentink commented 1 month ago

That could be a solution. As long as it's intuitive to the user of course. Because of work and other matters I don't have time coming few months to work on this.

I would very much welcome any contributions to this if you, or someone else, would be up for it!