search

martijnvanbrummelen / nwipe

nwipe secure disk eraser
GNU General Public License v2.0
688 stars 79 forks source link

HPA_DCO_012 Continuation of HPA/DCO integration #464

Closed PartialVolume closed 1 year ago

PartialVolume commented 1 year ago

Simplified the code that determines whether a HPA/DCO is present and in the process fixed some related bugs to do with the HPA/DCO fields in the PDF document displaying incorrect information in some drive specific cases.

mdcato commented 1 year ago

New wipe started with it, results in 12hrs or later.

(Sent from mobile)

From: PartialVolume @.> Sent: Tuesday, April 11, 2023 4:45:28 PM To: martijnvanbrummelen/nwipe @.> Cc: Subscribed @.***> Subject: [martijnvanbrummelen/nwipe] HPA_DCO_012 Continuation of HPA/DCO integration (PR #464)

Simplified the code that determines whether a HPA/DCO is present and in the process fixed some related bugs to do with the HPA/DCO fields in the PDF document displaying incorrect information in some drive specific cases.

You can view, comment on, or merge this pull request online at:

https://github.com/martijnvanbrummelen/nwipe/pull/464

Commit Summary

File Changes

(5 fileshttps://github.com/martijnvanbrummelen/nwipe/pull/464/files)

Patch Links:

— Reply to this email directly, view it on GitHubhttps://github.com/martijnvanbrummelen/nwipe/pull/464, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANGK2PQLO3HSOPKSHGBMHP3XAXGHRANCNFSM6AAAAAAW22KBWM. You are receiving this because you are subscribed to this thread.Message ID: @.***>

PartialVolume commented 1 year ago

New wipe started with it, results in 12hrs or later.

Thanks, it's still not perfect yet, wiping a old 2004 IDE 80GB drive this morning resulted in the wipe completing correctly but real size on the pdf being 512 bytes not the 80GB. This was because all HPA and DCO values were not present either due to the drive or the USB adapter I was using. So in that case when no HPA/DCO information is obtainable, the pdf code needs to assume real size = apparent size and make a note on the pdf that HPA/DCO data was unobtainable.

I'm going to fix that this afternoon and do another release tonight (GMT0).