search

martijnvermaat / calmap

Calendar heatmaps from Pandas time series data -- See https://github.com/MarvinT/calmap/ for the maintained version
https://pythonhosted.org/calmap
MIT License
211 stars 61 forks source link

Deprecation warnings with Matplotlib 2.0.x #19

Closed janik6n closed 3 years ago

janik6n commented 7 years ago

When run with Matplotlib 2.0.2 (Python 3.6.2) I get the following deprecation warnings:

/.../venv/lib/python3.6/site-packages/calmap/__init__.py:128: FutureWarning: how in .resample() is deprecated
the new syntax is .resample(...).sum()
  by_day = data.resample('D', how=how)
/.../venv/lib/python3.6/site-packages/calmap/__init__.py:146: MatplotlibDeprecationWarning: The get_axis_bgcolor function was deprecated in version 2.0. Use get_facecolor instead.
  linecolor = ax.get_axis_bgcolor()

Just a heads up for future proofing.

MarvinT commented 6 years ago

as of matplotlib 2.2.2 get_axis_bgcolor() has been removed and calmap no longer works

darkmatter2222 commented 3 years ago

Opened pull request https://github.com/martijnvermaat/calmap/pull/34 to fix, emailed @martijnvermaat to pull.

MarvinT commented 3 years ago

@darkmatter2222 , can you submit a PR to https://github.com/MarvinT/calmap/ as well. Thats the version that currently gets published to pypi. Unless @martijnvermaat wants to take over the repo maintenance again.

darkmatter2222 commented 3 years ago

@MarvinT got some conflicts there m8 https://github.com/MarvinT/calmap/pull/11

martijnvermaat commented 3 years ago

Right! I knew someone had offered help before, but I completely forgot about this!

@MarvinT Since it sounds you're still interested in keeping your version maintained, let's promote that to the be the main repo. I can add a notice on this repo and in the README pointing to yours, and also mention in all open issues and pull request.

@darkmatter2222 It would be great if you could submit the same PR to @MarvinT 's fork, thanks!

darkmatter2222 commented 3 years ago

@martijnvermaat, https://github.com/MarvinT/calmap/pull/11 submitted, in @MarvinT bucket now.

darkmatter2222 commented 3 years ago

closed https://github.com/MarvinT/calmap/pull/11, the source is nothing alike. @MarvinT had this solved for in another way.

I would say this repo is also out of date too. thanxz all!

MarvinT commented 3 years ago

@darkmatter2222 yup, I think solving this issue is what prompted me to take over maintenance of the repo in the first place. Definitely let me know if there are any new features fixes you'd like to add over there

MarvinT commented 3 years ago

Hi, if this problem still exists and you'd like to create a PR to fix it please direct it to https://github.com/MarvinT/calmap/ That is the version that gets published to pypi and has received several updates to fix some existing issues.

martijnvermaat commented 3 years ago

Thank you for creating the issue. Unfortunately I don't have the time to maintain this project. As per @MarvinT 's comment, please see https://github.com/MarvinT/calmap/ instead.