search

martijnvermaat / calmap

Calendar heatmaps from Pandas time series data -- See https://github.com/MarvinT/calmap/ for the maintained version
https://pythonhosted.org/calmap
MIT License
211 stars 61 forks source link

updates for new matplotlib #22

Closed MarvinT closed 5 years ago

MarvinT commented 6 years ago

addresses issue #19 compatible with any matplotlib 2.0+

diimdeep commented 6 years ago

Looks good!

onesuper commented 6 years ago

Hope this PR can be merged

rubik commented 6 years ago

@martijnvermaat Can you merge this one and release please? The package is otherwise unusable.

martijnvermaat commented 6 years ago

Thanks for the contribution. The tests are failing (looks like because of some other matplotlib change) which makes it hard for me to merge. I'm more than happy to merge if the tests are fixed.

I don't use the package myself at the moment and don't really have time to look into it. If someone feels like maintaining it, feel free to fork.

MarvinT commented 6 years ago

Hey @martijnvermaat,

I could help maintaining it. Can you add me on pypi? https://pypi.org/user/marvint/

I'll try to look at the unit tests.

MarvinT commented 6 years ago

It seems the baseline pngs vary from system to system... I've tried generating them on several different machines and haven't been able to find a set that matches the travis-ci versions. Are you ok with me removing the comparison and just testing to see if the function calls complete without error?

MarvinT commented 6 years ago

I removed the mpl test comparison to the generated plots because they were different on every machine I built on and I never got a version that matched travis-ci. It might be possible to generate them using debug mode in travis if you really want to.

Also fixed a bunch of other small issues to get docs to build. It looks like it might be a good time to update the version number and possibly add me as a collaborator/maintainer 😉

ErikBjare commented 6 years ago

@martijnvermaat Please merge this and push it to pypi :heart:

rubik commented 6 years ago

@martijnvermaat Can you merge this and publish a new version?

MarvinT commented 5 years ago

Hey all, I'm going to be taking over maintenance of calmap over on my repo: https://github.com/MarvinT/calmap/ . I'll try to push version 0.0.7 to pypi today with these fixes.