search

martijnversluis / ChordSheetJS

A JavaScript library for parsing and formatting chords and chord sheets
https://github.com/users/martijnversluis/projects/4
GNU General Public License v2.0
318 stars 50 forks source link

Improve chord parsing in ChordSheetParser #482

Closed martijnversluis closed 1 year ago

martijnversluis commented 2 years ago

As concluded in #461, the chord parsing format in ChordSheetParser is not inclusive enough and not consistent with how Chord.parse functions. The format should be extended to match all possible chords. If possible, it would be nice to have shared logic for recognising and parsing chords.

paulrobertpine commented 2 years ago

I'm not sure how he ChordProParser HtmlDivFormatter chooses how to make paragraphs. I have what I think are 2 identical formats but one is making paragraphs after every line and the other behaves what I would consider correctly.

martijnversluis commented 2 years ago

Hi @paulrobertpine,

Thanks for reaching out. I think what you're describing is different from this issue here. Would you mind creating a new issue, also providing the code and chord sheet(s) you're using? I'll try if I can find a solution.