Closed Zrp200 closed 9 years ago
There are couple of ideological and practical issues with this short cut:
ScoreSheet
object is now doing functions that have already been established in Dice
. Rewriting already established functions is a waste of resources.ScoreSheet
is handling the functions of the dice. At this rate, the only thing ScoreSheet
is not doing is roll
and roll_all
. Dice
class must remain as an independent and meaningful class.dice2
is not behaving as expected is because in scoresheet.rb
there are two methods defined for dice2
- one which takes no arguments and another with one argument.dice2
is not descriptive. When I woke up this morning and saw that, I thought it had something to do with the second dice in the array.dice2
is having the opposite effect if it is causing test failures.
dice2
always ends up returning0
need to investigate