search

martin-braun-net / google_maps_place_picker_mb

Place picker on Google Maps for Flutter
https://pub.dev/packages/google_maps_place_picker_mb
MIT License
33 stars 96 forks source link

Update pubspec.yaml #50

Closed giorgio79 closed 1 year ago

giorgio79 commented 1 year ago

unnecessary location import since package uses geolocator (competing packages)

martin-braun commented 1 year ago

Which package exactly causes the conflict? Did you also verify the example project compiles after flutter clean && flutter pub get?

Thanks!

giorgio79 commented 1 year ago

Yes, spoke too soon! Found some usages of Location in the package. Not exactly a conflict, just that location and geolocator do the same thing, so one should be enough probably. Also, watch out as there is a big crash coming with the latest Flutter and Location package https://github.com/Lyokone/flutterlocation/issues/800 and the package seems to be less and less maintained judging by the issue queue

martin-braun commented 1 year ago

@giorgio79 This package drags a lot of ancient stuff with it unfortunately. Things need to change, but I don't know if I can occupy enough time to do it (soon). I will try to look into the crash later, thanks for bringing this up.

giorgio79 commented 1 year ago

Thx Martin yeah, I dropped all Flutter Location form my code, but the app was still pulling it in, and it took some time to figure out that Place Picker is pulling it in. Here is the problem https://github.com/Lyokone/flutterlocation/issues/802

giorgio79 commented 1 year ago

Looks like Location plugin is only requesting permission from the user to use the smartphone's location. Do we want to keep this functionality in here? Perhaps we can rip it out completely and make sure the user takes care of that themselves. I would be happy to look into a patch :)

martin-braun commented 1 year ago

@giorgio79 Requiring the user to take care of the location permission sounds right, but it would be a breaking change, which I'm not a fan of. Maybe it was better to integrate the permission request into the place picker itself (in case no permission is available yet).

We might as-well just look for an alternative package that is properly maintained, in case of too great logic that we don't want to re-invent.

You are absolutely welcome to patch it. Any improvement is much appreciated, just branch off the dev-branch is my personal recommendation. :)