search

martin-bts / askbot-devel

Askbot is a Django/Python Q&A forum. **Contributors README**: https://github.com/ASKBOT/askbot-devel#how-to-contribute. Commercial hosting of Askbot and support are available at https://askbot.com
Other
0 stars 2 forks source link

remove Coffin #13

Closed sebastian-philipp closed 5 years ago

sebastian-philipp commented 5 years ago

https://pypi.org/project/Coffin/

martin-bts commented 5 years ago

Coffin added a lot of things to Jinja2 to add things that are specific for Django templates. The native Django-Jinja2 integration leaves Jinja2 environments unchanged on purpose, as summarized here on Stack Exchange. The original source is claimed to be the Django documentation

We are a bit in between at the moment. For instance, our templates do contain {% load %} tags but (at least in Coffin >= 2.0) this tag is only a noop.

We cannot use the django.template.Library, because it is not meant to enrich Jinja2 environments. The library provided by django_jinja is.

sebastian-philipp commented 5 years ago

I have the impression that removing the coffin dependencies of askbot/templatetags/extra_filters_jinja.py is an achievable goal. The only thing needed is an inspiration of how to replace coffin there. (That's of course independent of the HTML templates.)