search

martin-g / wicket-bootstrap

Apache Wicket components for Twitter Bootstrap - Wicket-Bootstrap is based on Twitter's toolkit (bootstrap) and the Apache Wicket Framework.
https://wicketbootstrap.teliclab.info/
296 stars 162 forks source link

NavbarDropDownButton with bootstrap-4 incorrectly show #795

Open bochkov-vi opened 5 years ago

bochkov-vi commented 5 years ago

NavbarDropdownButton incorrectly renders button with attribute type="button" its add border around of component and remove background color to fix i need

.. new NavbarDropDownButton(...) {
      ....
        }.addToButton(new AttributeModifier("type",AttributeModifier.VALUELESS_ATTRIBUTE_REMOVE))....
martin-g commented 5 years ago

Please give some more information. It is nearly impossible to find out what should be fixed from this short description and code snippet.

bochkov-vi commented 5 years ago

i use maven dependency <wicket-bootstrap.version>3.0.0-M8</wicket-bootstrap.version>

NavbarDropDownButton extends DropDownButton where in markup file ... <a class="dropdown-toggle" wicket:id="btn" type="button" data-toggle="dropdown" aria-haspopup="true" href="javascript:;" aria-expanded="false"> ... type="button" makes NavbarDropDownButton show border and lost backgraund color

bochkov-vi commented 5 years ago

I think it is necessary to make the "type" attribute customizable for baseButton in DropDownButton class when NavbarDropDownButton exending, remove it value from markup when initilizing