Allows :dql_parameters with ARRAY_* functions

martin-georgiev / postgresql-for-doctrine

PostgreSQL enhancements for Doctrine. Provides support for advanced data types (json, jssnb, arrays), text search, array operators and jsonb specific functions.

https://packagist.org/packages/martin-georgiev/postgresql-for-doctrine

MIT License

362 stars 44 forks source link

Allows :dql_parameters with ARRAY_* functions #240

Closed allan-simon closed 3 weeks ago

allan-simon commented 1 month ago

before it was only possible to do ARRAY_APPEND(e.myarray, 'a_literal') so it was impossible to have the value coming from php (without resorting to DQL injection)

We now allow also the following syntax ARRAY_APPEND(e.myarray, :foobar)

allan-simon commented 1 month ago

compare to the other PR I've added additional test and used ArithmeticPrimary that allow both Literal and input parameters , as well as other methods returning string (which allow chaining calls )

martin-georgiev commented 4 weeks ago

I think only CI failure remains to be addressed. Thank you 😊

allan-simon commented 4 weeks ago

@martin-georgiev it was some coding style issue, should be good now :)

allan-simon commented 4 weeks ago

@martin-georgiev sorry, i was a bit fast in the correction of the coding style, it's ok now, the scrutinizer error is a timeout so i think it's just need a relaunch ?