search

martin-ger / esp_mqtt

MQTT Broker/Bridge on the ESP8266
MIT License
295 stars 69 forks source link

Code review #17

Closed miolion closed 6 years ago

miolion commented 6 years ago

I am not sure whether this fixes the out of mem issue by adding the following condition of NULL password checking prior to the authentication callback.

    if (password == NULL) {
        MQTT_WARNING("MQTT: Password invalid\r\n");
        MQTT_server_disconnectClientCon(clientcon);
        return;
    }

SJ

miolion commented 6 years ago

Martin, you did a nice job!