search

martin-helmich / typo3-typoscript-lint

Find coding errors in your TypoScript files.
MIT License
82 stars 19 forks source link

Add sniff which check for config.no_cache=1 usages #105

Closed tmotyl closed 3 years ago

tmotyl commented 3 years ago

Usage of the config.no_cache is discouraged as it result in performance penalty when multiple requests are coming in parallel (high lock waits). Instead USER_INT or COA_INT should be used.

solves: https://github.com/martin-helmich/typo3-typoscript-lint/issues/102

tmotyl commented 3 years ago

The build error seems not related to this change (phar packaging failed).

martin-helmich commented 3 years ago

Agreed, the failing build is definitely unrelated to your change. Will review asap! :+1:

martin-helmich commented 3 years ago

Side note @tmotyl: If you rebase your changes on top of the current master, all CI workflows should now pass (fixed in #106).

martin-helmich commented 3 years ago

:+1: LGTM! Thanks for your contribution!

tmotyl commented 3 years ago

Yay! Thanks