search

martin-helmich / typo3-typoscript-lint

Find coding errors in your TypoScript files.
MIT License
82 stars 19 forks source link

WIP: Implement automatic fixing of found issues #91

Open martin-helmich opened 4 years ago

tmotyl commented 3 years ago

Hi What is missing to have that merged? Can I help somehow?

martin-helmich commented 3 years ago

TBH, I kind of lost track of this one. I still remember this PR involving quite a bit of refactoring, before my attention shifted elsewhere...

My intention was to implement a few of the auto-fixes by manipulating the AST and then re-generating the code from the AST. However, the drawback of that solution was that many finer formatting details (and also comments, iirc) were lost. I still remember thinking about refactoring the parser to generate an AST with nodes that have additional positional metadata to allow for selective re-generation of specific parts of the program, when my attention shifted away from this issue.

With the christmas break coming up (and not much else to do during lockdown 😷) I might actually find some time to pick this up again and maybe give it another push. 🙂