search

martin-lueders / ML_modules

free modules for VCV Rack
BSD 3-Clause "New" or "Revised" License
90 stars 18 forks source link

almost all modules crashing in Rack dev version(s) #14

Closed davephillips closed 6 years ago

davephillips commented 6 years ago

Hi Martin,

The dev builds are completing without complaint, but the modules are crashing both dev versions on my machine (the only one that works is the h-bar quantizer). My Rack "stable" dev version is commit 0e7e3625657e8e8fd875429ebc5892a0e5b384fd and my testing version is commit e46448150db970c874b66682ed27f51c231e1372. No error messages are reported, so I['m stumped about debugging the problem. Any suggestions ? Btw, a core dump occurs, if I can find the core image I can run it in gnu's dbg.

Edited: After trying to load the OctaFlop the Rack crashed as expected, but this time I got a little more from the error report:

Rack: src/app/ColorLightWidget.cpp:14: virtual void rack::ColorLightWidget::step(): Assertion `module->lights.size() >= lightId + colors.size()' failed.

Edit: Woops, I just noticed that there's no OctaFlop.svg, my bad.

Best,

dp

davephillips commented 6 years ago

Okay, some follow-up. I now have the following modules working in the latest dev version of Rack (Linux, Fedora 23) : Quantizer, Quantum, SeqSwitch, SeqSwitch2, ShiftRegister, Freeverb, Constants, Counter, and VoltMeter. However, I think I'm working from an older ML_modules codebase, so I'll redo everything from the latest git pulls. Btw, I was really missing the SeqSwitch when working with the latest dev Rack. :)

davephillips commented 6 years ago

Updated to latest pull of ML_modules. Biggest fix was simply adding a missing NUM_LIGHTS to the module declarations for FreeVerb, OctaFlop, Quantum, SeqSwitch, SeqSwitch2, ShiftRegister and TrigBuf, i.e. change SeqSwitch() : Module (NUM_PARAMS, NUM_INPUTS, NUM_OUTPUTS ) {}; to SeqSwitch() : Module (NUM_PARAMS, NUM_INPUTS, NUM_OUTPUTS, NUM_LIGHTS ) {};

SVG files are missing for BPMdetect, OctaFlop, and SH8 modules, but you probably know that already. :)

All modules now load and work in the latest dev Rack.