search

martin-lueders / ML_modules

free modules for VCV Rack
BSD 3-Clause "New" or "Revised" License
90 stars 18 forks source link

modules missing NUM_LIGHTS #15

Closed davephillips closed 6 years ago

davephillips commented 6 years ago

[dlphilp@The6300 src]$ grep NUM_LIGHTS . FreeVerb.cpp: NUM_LIGHTS OctaFlop.cpp: NUM_LIGHTS Quantum.cpp: NUM_LIGHTS SeqSwitch2.cpp: NUM_LIGHTS SeqSwitch.cpp: NUM_LIGHTS ShiftRegister.cpp: NUM_LIGHTS TrigBuf.cpp: NUM_LIGHTS

All these files include an incomplete module statement. For example, this :

FreeVerb() : Module( NUM_PARAMS, NUM_INPUTS, NUM_OUTPUTS ) {

will crash the latest Rack. This will fix the problem :

FreeVerb() : Module( NUM_PARAMS, NUM_INPUTS, NUM_OUTPUTS, NUM_LIGHTS ) {

Best regards,

dp

martin-lueders commented 6 years ago

I have added all NUM_LIGHTS now. It builds on my system, so I hope it is fixed now.