martin-lueders / ML_modules

free modules for VCV Rack
BSD 3-Clause "New" or "Revised" License
90 stars 18 forks source link

BPM Tools: readout shows BPM/2 #25

Closed phdsg closed 6 years ago

phdsg commented 6 years ago

OS: win Rack: dev Plugin: dev

input on the module is JW clock set to 60bpm. readout on bpmtools shows 30.0.

martin-lueders commented 6 years ago

Do you have a new version of JW clock? Mine does not show any bpm value...

phdsg commented 6 years ago

no, jw doesn't have a readout (yet. requested one). do you want to know how i checked that it's actually 60? i wanted to set up a stop-watch using 2 of your counters (one for seconds one for minutes) and a clock. setting the clock manually using your bpm analyzer to 60bpm made the "seconds-counter" tick twice every second.

this is how it looks when it's set up so the seconds timer ticks in sync with my clock on the wall. bpmtools

martin-lueders commented 6 years ago

I think you are fooled by some missed beats, which can happen if some signal paths have a 1 module delay while others are direct.

You can do two tests you can do: If you set the speed of 60 bpm you should get 1 beat per second, which is easy to check. You can also put it after Autodafe's BPM clock, and see that you get a consistent results.

phdsg commented 6 years ago

i'll do some more checks...

phdsg commented 6 years ago

here's how it looks with autodafe clock set up to sync the counter with realtime seconds. bpmtools2

and here's one with luckyxxl tick. bpmtools3

phdsg commented 6 years ago

oh my, that is weird... i checked again with a soundgenerator so i'm not fooled by my eyes and low and behold, all numbers are good.

can be closed i guess as it's only happening with no core/audiodevice

martin-lueders commented 6 years ago

OK. I just checked against luckyxxx again.

I guess the confusing thing is that they work differently. While Autodafe's BPM clock gives one tick per beat, meaning the '1' output gives 2 beats per second at 120 bpm, the lucky one gives it relative to 'bars', not beats' His plugin gives a tick only at the beginning of a bar (4 beats) at the '1/1' output, and you need the '1/4' output to get a tick per beat.

Unfortunately, both could be abbreviated with BMP: "beats per minute" or "bars per minute".

But is looks my BPM tool (and I refer to BEATS per minute) works fine. It should not have anything to do with core or audiodevices attaches.

The problem in your first post might be related to the fact I explained, that you could loose the first beet in the counter if the pulse on "Start" comes one sample delayed (which would happen due to the inserted UTILITY modules. Try to insert a MULTIPLY or something else in the other signal path as well.

Hope that helps. Martin

phdsg commented 6 years ago

although this is not an issue anymore, you can check what i meant with the audio-device using this setup.

bpmtools4

with audio device selected the system behaves correctly. 1 tick per second. with no audio device selected it ticks faster.