search

martin-lueders / ML_modules

free modules for VCV Rack
BSD 3-Clause "New" or "Revised" License
90 stars 18 forks source link

small issue about paths #5

Closed antoniograzioli closed 6 years ago

antoniograzioli commented 6 years ago

I had blank panels after building your modules, simply because your repo is "ML-modules" but the code uses "plugins/ML_modules" for graphics

just renaming it corrrected the issue

martin-lueders commented 6 years ago

I noticed that.

I am not quite sure how to solve it. I don't seem able to rename the repository. And I am a bit fearful that having a '-' in the path might give problems on some platforms.

I guess (hope!) that with the 0.4.0 version and the asset() function, the pathname should no longer be relevant.

antoniograzioli commented 6 years ago

yes, v 0.4.0 should solve the problem, since you simply write:

panel->setBackground(SVG::load(assetPlugin(plugin, "res/MyImage.svg")));

so the folder shouldn't be relevant anymore.

BTW you can rename your repo by simply going to "Settings" on top of your repo (that's what I did this morning ) ^^

martin-lueders commented 6 years ago

I renamed the repository now. If you already have it cloned, simply rename the ML-modules directory to ML_modules.

Anyway, with rack 0.4.0 that should become irrelevant.