martin-lueders / ML_modules

free modules for VCV Rack
BSD 3-Clause "New" or "Revised" License
90 stars 18 forks source link

Quantum Note Toggle not working in 1.0 #53

Closed MaZe6K closed 5 years ago

MaZe6K commented 5 years ago

Hello!

First of all Thank You for your great modules!

It appears that the Note Toggle of Quantum is not working in 1.0. My uninformed non-coder guess is that this has something to do with polyphony. It reacts to a polyphonic signal, but the notes switch off after the gate ends. With a monophonic signal all notes stay off all the time.

martin-lueders commented 5 years ago

Sorry, I did not manage to write a new manual yet. This is not a bug but a feature.

If the note select and note toggle are monophonic, it reacts as before. When these cables are polyphonic, it toggles each note with the corresponding gate, i.e. you can play the Quantum like an arpeggiator with a keyboard.

I might implement a menu settings to prevent that and force the old way, even with polyphonic inputs.

On Sun, Jun 23, 2019 at 12:52 PM MaZe6K notifications@github.com wrote:

Hello!

First of all Thank You for your great modules!

It appears that the Note Toggle of Quantum is not working in 1.0. My uninformed non-coder guess is that this has something to do with polyphony. It reacts to a polyphonic signal, but the notes switch off after the gate ends. With a monophonic signal all notes stay off all the time.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/martin-lueders/ML_modules/issues/53?email_source=notifications&email_token=AHT5VYHCSRKB5B7C7U5OOVDP35PW7A5CNFSM4H2YXDA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3EOBZQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AHT5VYHEY6Z46BAVCYBUD4TP35PW7ANCNFSM4H2YXDAQ .

MaZe6K commented 5 years ago

Oh that's actually really nice! So with polyphonic input it's working and I love it!

But with monophonic input it doesn't work for me at all - all lights stay off when note and toggle are connected to a monophonic signal here (on Windows 7).

martin-lueders commented 5 years ago

Should be fixed in the next version. I also noticed some issues with that and I am working on it.

On Sun, Jun 23, 2019 at 10:30 PM MaZe6K notifications@github.com wrote:

Oh that's actually really nice! So with polyphonic input it's working and I love it!

But with monophonic input it doesn't work for me at all - all lights stay off when note and toggle are connected to a monophonic signal here (on Windows 7).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/martin-lueders/ML_modules/issues/53?email_source=notifications&email_token=AHT5VYFGTPS2EDEI3FH2RDTP37TPRA5CNFSM4H2YXDA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYLHPHY#issuecomment-504788895, or mute the thread https://github.com/notifications/unsubscribe-auth/AHT5VYCKBAQLACFGSDKKSWLP37TPRANCNFSM4H2YXDAQ .

MaZe6K commented 5 years ago

Everything working beautiful now! Thank You!