search

martin-lueders / ML_modules

free modules for VCV Rack
BSD 3-Clause "New" or "Revised" License
90 stars 18 forks source link

Feature Request - Shift Register poly sum #63

Open omricohenmusic opened 4 years ago

omricohenmusic commented 4 years ago

Hi Martin! I was thinking, maybe it's possible to have an option on the Shift Register to sum a few outputs to one poly signal? So for example, If I want to merge the first 4 outputs, I can choose this in the right-click menu (similar to Chords from VCV), and then I will have a poly signal from the 4th output instead of using a dedicated merge module. What do you think? Thanks!

martin-lueders commented 4 years ago

Hi Omri,

Thanks for the suggestion. It sounds like a good idea. However, there is one detail, I am wondering about: The Shift Register already works polyphonically, so I could only combine the outputs of one poly channel into one new polyphonic output. Would it be too confusing is such polyphonic output, as you suggest, only works for the first poly-channel?

I have a crazy idea, but don't know whether it is doable at the moment. I could make the poly-output as an expander module (maybe together with some sort of selection which stages you want to combine). If possible, I could make the expander such that you could stack them up, and the first expander would combine the values of the first poly-channel of the Shift Register, a second expander, stacked onto them would combine the second poly channel, etc.

What do you think?

Cheers, Martin

On Sat, Feb 1, 2020 at 6:21 PM omricohenmusic notifications@github.com wrote:

Hi Martin! I was thinking, maybe it's possible to have an option on the Shift Register to sum a few outputs to one poly signal? So for example, If I want to merge the first 4 outputs, I can choose this in the right-click menu (similar to Chords from VCV), and then I will have a poly signal from the 4th output instead of using a dedicated merge module. What do you think? Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/martin-lueders/ML_modules/issues/63?email_source=notifications&email_token=AHT5VYDPGEWFI3PDQ3TDF7DRAWVRXA5CNFSM4KOUKL2KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IKLDEYQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHT5VYA7SXFQPW5X7KLK4WTRAWVRXANCNFSM4KOUKL2A .

omricohenmusic commented 4 years ago

Hi Martin,

Well, maybe the simplest thing to do is have another "monophonic" mode when using a monophonic signal. That way it will be possible to merge a few outputs within the module unless using already a poly signal in the polyphonic mode. And of course, the polyphonic mode will be the default one so it will not break any patches I guess. Another idea will be, if we're already talking about expanders, is to have a merge expander with one output and a few switches for each output of the Shift Register. It will be like adding a merge module but without the need to connect any cables. If it's getting too complicated then maybe it's better to leave this how it is now. I mean, it's not such a big deal to add a merge module, I just thought it will be nice to make it within the module itself. By the way, and let me know if I should open a separate card for this, but I noticed that the OctaTrigger is quite heavy on CPU. Do you think it's possible to improve it?

Thanks again!

Omri

Omri Cohen

[https://docs.google.com/uc?export=download&id=0B8K00I2KYl3abnExMEkyNGRPbWc&revid=0B8K00I2KYl3aT0xhRkhBcFU3Zk5YeWZrRFMrNitpRElSUWo0PQ]http://omrico1983.wixsite.com/omricohencomposer https://soundcloud.com/omricohencomposer/tracks [https://docs.google.com/uc?export=download&id=0B8K00I2KYl3aMXU1emw5eVZIODA&revid=0B8K00I2KYl3aRHRtN0l5R2w2bG42UzQzMmF6WEVpL3JNMnpzPQ] https://www.facebook.com/omricohenmusic/ [https://docs.google.com/uc?export=download&id=0B8K00I2KYl3aY0ZmdDJVRTkyWVE&revid=0B8K00I2KYl3ab2s2Qm5XNDg5c1d0RlVyTE5XWUVwOXBHbERzPQ] https://soundcloud.com/omricohencomposer/tracks [https://docs.google.com/uc?export=download&id=0B8K00I2KYl3aM2VYYkdMOTBibEE&revid=0B8K00I2KYl3aY2pJcTcycHhDc2ZkeEpsUHlVd25sS0RmQVpnPQ] https://www.instagram.com/omricohencomposer/?hl=en [https://www.linkedin.com/in/omri-cohen-b01b70150/] https://www.linkedin.com/in/omri-cohen-b01b70150/ [https://docs.google.com/uc?export=download&id=0B8K00I2KYl3abkliN1pfQk5lSG8&revid=0B8K00I2KYl3aZ2Q5R0lINlVYZ0RDeWI4Um53Z3NSdG1La3NvPQ] https://omricohencomposer.bandcamp.com/

https://www.facebook.com/omricohenmusic/ https://www.facebook.com/omricohenmusic/

From: Martin Lueders notifications@github.com Sent: Sunday, February 23, 2020 3:02 PM To: martin-lueders/ML_modules ML_modules@noreply.github.com Cc: omricohenmusic omri_co1983@hotmail.com; Author author@noreply.github.com Subject: Re: [martin-lueders/ML_modules] Feature Request - Shift Register poly sum (#63)

Hi Omri,

Thanks for the suggestion. It sounds like a good idea. However, there is one detail, I am wondering about: The Shift Register already works polyphonically, so I could only combine the outputs of one poly channel into one new polyphonic output. Would it be too confusing is such polyphonic output, as you suggest, only works for the first poly-channel?

I have a crazy idea, but don't know whether it is doable at the moment. I could make the poly-output as an expander module (maybe together with some sort of selection which stages you want to combine). If possible, I could make the expander such that you could stack them up, and the first expander would combine the values of the first poly-channel of the Shift Register, a second expander, stacked onto them would combine the second poly channel, etc.

What do you think?

Cheers, Martin

On Sat, Feb 1, 2020 at 6:21 PM omricohenmusic notifications@github.com wrote:

Hi Martin! I was thinking, maybe it's possible to have an option on the Shift Register to sum a few outputs to one poly signal? So for example, If I want to merge the first 4 outputs, I can choose this in the right-click menu (similar to Chords from VCV), and then I will have a poly signal from the 4th output instead of using a dedicated merge module. What do you think? Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/martin-lueders/ML_modules/issues/63?email_source=notifications&email_token=AHT5VYDPGEWFI3PDQ3TDF7DRAWVRXA5CNFSM4KOUKL2KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IKLDEYQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHT5VYA7SXFQPW5X7KLK4WTRAWVRXANCNFSM4KOUKL2A .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/martin-lueders/ML_modules/issues/63?email_source=notifications&email_token=AMMPP66E4AEPKFL5BBUYK3TREJ6YPA5CNFSM4KOUKL2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMV4Q2Y#issuecomment-590071915, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMMPP64733BSL7DQPWDTXQLREJ6YPANCNFSM4KOUKL2A.