Closed alyssa-dahlberg closed 10 years ago
Hi Guys, Thanks for the pull request. I agree with all you code changes you made. So I will accept it soon (just need to do some more testing)
As you might notice, I believe good documentation is the key for more adoption and contribution to Amazing Cloud Search. Can you update the documentation using "Id" instead of "id" ? I'm glade you discover how to use capitale letter using "JsonProperty". I think we should now update our documentation and code for the Movie class into:
public class Movie : CloudSearchDocument
{
[JsonProperty("actor")]
public List<string> Actor { get; set; }
[JsonProperty("director")]
public string Director { get; set; }
[JsonProperty("mydate")]
public DateTime MyDate { get; set; }
public string title { get; set; } // without "JsonProperty", property can't have contain any capital letters
[JsonProperty("Year")]
public int Year { get; set; }
}
And finally update and explain why we are using "JsonProperty" by replacing the current documentation: "Object field starts in lowercase because THEY NEED to match the field name in your index. This needs to be improved (feel free)"
Hope you share the same vision
Heya, for some reason I can't find your or your repository at all now, any idea what's happened? This page gives me 404, Not Found:
https://github.com/martin-magakian/Amazing-Cloud-Search
On 5 February 2014 23:55, Martin Magakian notifications@github.com wrote:
Hi Guys, Thanks for the pull request. I agree with all you code changes you made. So I will accept it soon (just need to do some more testing)
As you might notice, I believe good documentation is the key for more adoption and contribution to Amazing Cloud Search. Can you update the documentation using "Id" instead of "id" ? I'm glade you discover how to use capitale letter using "JsonProperty". I think we should now update our documentation and code for the Movie class into:
public class Movie : CloudSearchDocument { [JsonProperty("actor")] public List
Actor { get; set; } [JsonProperty("director")] public string Director { get; set; } [JsonProperty("mydate")] public DateTime MyDate { get; set; } public string title { get; set; } // without "JsonProperty", property can't have contain any capital letters [JsonProperty("Year")] public int Year { get; set; }
}
And finally update and explain why we are using "JsonProperty" by replacing the current documentation: "Object field starts in lowercase because THEY NEED to match the field name in your index. This needs to be improved (feel free)"
Hope you share the same vision
Reply to this email directly or view it on GitHubhttps://github.com/martin-magakian/Amazing-Cloud-Search/pull/11#issuecomment-34155757 .
I've now added some new info to the docs plus improved the formatting a bit.
I don't know what append with this 404 error. Anyway nicely done for the documentation.
This pull contains a small addition I've made to allow searching default text fields using the boolean queries. I've also included dwaynew's changes since our build uses those as well. Let me know if there's anything you'd like done differently, and thanks for the client :+1: