search

martin-magakian / Amazing-Cloud-Search

Allow you to search, faceted search, add, update, remove objects from your Amazon Cloud Search Index in C#.
30 stars 17 forks source link

Batch update support & better delete methods #6

Closed AutoGibbon closed 10 years ago

AutoGibbon commented 10 years ago

Added support for batch updates with an overload of Update(TDocument) - Update(List). Changed Delete methods to accept TDocument and List(TDocument) instead of accepting the ICloudSearchDocument interface itself.

AutoGibbon commented 10 years ago

Unit test TestCRUD passes with the changes I have made. I thought it was a bit odd that the Delete method accepts ICloudSearchDocument - considering that the List overload of this method breaks if you are trying to pass Lists of types that implement it instead of a list of the interface type.

martin-magakian commented 10 years ago

Humm Yes I wonder why we used ICloudSearchDocument instead of TDocument. I was a mistake I guess. Thanks for your commit, all your change are now in the master branch.

AutoGibbon commented 10 years ago

Great stuff. I'll pull down the latest nuget version if it is available. On 20 Oct 2013 17:25, "Martin Magakian" notifications@github.com wrote:

Humm Yes I wonder why we used ICloudSearchDocument instead of TDocument. I was a mistake I guess. Thanks for your commit, all your change are now in the master branch.

— Reply to this email directly or view it on GitHubhttps://github.com/martin-magakian/Amazing-Cloud-Search/pull/6#issuecomment-26676357 .