martin-marek / hdr-plus-swift

📸Night mode on any camera. Based on HDR+.
https://burst.photo
GNU General Public License v3.0
208 stars 11 forks source link

Metadata not copied properly #15

Closed Alex-Vasile closed 1 year ago

Alex-Vasile commented 1 year ago

(This is true even when running with #13, I am putting this up for later)

The merged photo does not have all of the information copied correctly from the input files. E.g. lens correction and lens info is not copied correctly. The lens info is somewhat there, but it's not entire correct, and the lens correction is not picked up at all.

chris-rank commented 1 year ago

The DNG SDK can be very confusing and I spent a lot of time fixing one line of code for copying the maker notes (camera manufacturer specific information) correctly. For my RAW converter (DXO Photolab), all required information is there that I do not see a difference in the behavior of the output DNG file compared to the original RAW file (running with #13). For which application do you see the difference / missing information?

Alex-Vasile commented 1 year ago

I double checked with DXO, and with simply converting a raw to dng using just the DNG convertor and it seems like they are converting properly.

The issue appears to be with Capture One, I will have to go complain to them. Something strange is going on with lens recognition as well as the WB. Same image in .ARW vs .DNG will have a slightly different tint.