search

martin-marek / hdr-plus-swift

📸Night mode on any camera. Based on HDR+.
https://burst.photo
GNU General Public License v3.0
210 stars 11 forks source link

Need X-Trans Exposure Bracketed Images for Testing #26

Open Alex-Vasile opened 1 year ago

Alex-Vasile commented 1 year ago

PR #23 adds support for reading black and white levels from X-Trans raw files, but handling of exposure bracketed images is not yet enabled since none of the current developers have an X-Trans camera to generate bracketed bursts in order to test them.

(The current X-Trans support has been tested using images found online, but we have not been able to find bracketed raw files anywhere).

If you are reading this and have some raw files that you'd be willing to share they'd be greatly appreciated. We need a burst of 2 images (minimum) with a different exposure compensation between them: e.g. one shot a 0EV and another having the exposure compensation dial set to +2EV (or -2EV).

Alex-Vasile commented 1 year ago

@SZim92, in #2, you asked for X-Trans support. Do you have access to a X-Trans camera? There's a few specific test photos that would be really helpful for enabling these features

dejanberic commented 1 year ago

Here are some RAF HDR files shot by me on my Fuji X-T20, which I do not have anymore (sold it).

https://mega.nz/folder/HPQhSRzB#at1mGj9VHf5dA3ySEJJKsw

Alex-Vasile commented 1 year ago

Here are some RAF HDR files shot by me on my Fuji X-T20, which I do not have anymore (sold it).

https://mega.nz/folder/HPQhSRzB#at1mGj9VHf5dA3ySEJJKsw

Thanks! These look good. I will use these to further test my PR (as soon as I find some time for it).

dejanberic commented 1 year ago

Awesome! Let me know once you copy those images so I can remove the public link.

Alex-Vasile commented 1 year ago

Awesome! Let me know once you copy those images so I can remove the public link.

Done.

What license are you sending these photos under?

dejanberic commented 1 year ago

I am not a license expert, never shared anything before under a license. So let me explain in simple terms. I retain the copyright. If you want to use those images under any circumstance except for developing and testing HDR Plus (code in this repository) you should contact me for approval. Images cannot be used for commercial use and cannot be used for private use.

Is that fair/good enough?

Alex-Vasile commented 1 year ago

I am not a license expert, never shared anything before under a license.

Neither am I. But I think we can be clear about what kind of usages you would be okay with.

So let me explain in simple terms. I retain the copyright. If you want to use those images under any circumstance except for developing and testing HDR Plus (code in this repository) you should contact me for approval. Images cannot be used for commercial use and cannot be used for private use.

Is that fair/good enough?

So if I understand correctly: the images you provided can be used only for developing and testing code for this repository (BurstPhoto).

I have two follow on questions:

  1. If in the future we set up a repository of images that we use for automated testing, which would likely be publicly accessible, do we have your permission to include the images you sent into the repository?
  2. Can these images be used to show how the application works? I.e. a before and after, such as this image from the front page of the repo or the comparison image in the PR for bracketed bursts?
dejanberic commented 1 year ago
  1. Yes, you can use them for automated testing, but make sure that you point out the license for those images on your repository.
  2. Yes, they can be used to show how the application works.
Alex-Vasile commented 1 year ago
  1. Yes, you can use them for automated testing, but make sure that you point out the license for those images on your repository.
  2. Yes, they can be used to show how the application works.

Thank you!

Alex-Vasile commented 1 year ago

@dejanberic, could I bother you to also send a few photos my way with hot pixels?

I need a burst of uniform exposure images of a real scene (not the inside of a lens cap) but with dark frame subtraction turned off (if your camera has it). It will be names something like long exposure noise reduction or similar.

I have something that I think is a working version of the hot pixel correction, but I can't tell for sure without images that I too have hot pixels.

chris-rank commented 1 year ago

One option could be a burst with uniform exposure of the night sky with long exposure times of several seconds (5-10 seconds) and high iso.

dejanberic commented 1 year ago

@Alex-Vasile Here you go: https://mega.nz/file/iTB10J5C#MV2sdw7Ny5yWL1rVjNw0VuuOwyR804EoScuanz09jp8

I hope that will suffice. Note that I have sold my Fuji almost a year ago, so I can't do anything new, only dig trough my archive. I do have Sony A7 IV in case you need any samples from that camera.

Please let me know once you download the images so I can remove the link. The same license as above applies to these images.

Alex-Vasile commented 1 year ago

@Alex-Vasile Here you go:

https://mega.nz/file/iTB10J5C#MV2sdw7Ny5yWL1rVjNw0VuuOwyR804EoScuanz09jp8

I hope that will suffice.

Note that I have sold my Fuji almost a year ago, so I can't do anything new, only dig trough my archive.

I do have Sony A7 IV in case you need any samples from that camera.

Please let me know once you download the images so I can remove the link.

The same license as above applies to these images.

Downloaded.

These look great, thanks.