Automatically Convert non-DNG raws to DNG

martin-marek / hdr-plus-swift

📸Night mode on any camera. Based on HDR+.

https://burst.photo

GNU General Public License v3.0

198 stars 9 forks source link

Automatically Convert non-DNG raws to DNG #6

Closed Alex-Vasile closed 1 year ago

Alex-Vasile commented 1 year ago

I'm gotten part of the way there, but there' a few swift related things that I can't quite figure out.

[x] The CLI call can't find the files
[ ] The setting screen needs to have a file picker for selecting the location of the Converter
[ ] The current default path is hard-coded in. It should probably be blank by default, and have a function run on startup to check the default install location, but I am not sure where to put that.
[x] The user should be prompted if the path isn't set and a non-DNG file is found

Closes #4

martin-marek commented 1 year ago

Thanks, Alex! I'll try to take a look at this over the weekend.

martin-marek commented 1 year ago

I realized that Adobe DNG Converter has an installation package that will install it in /Applications/Adobe DNG Converter.app by default. So I simply check that path, ignoring the possibility of a different path.

I merged this into main and released it as part of v1.2 – now available on App Store and as a GitHub release. Hope it works and thanks for all your help!

Alex-Vasile commented 1 year ago

I realized that Adobe DNG Converter has an installation package that will install it in /Applications/Adobe DNG Converter.app by default. So I simply check that path, ignoring the possibility of a different path.

I merged this into main and released it as part of v1.2 – now available on App Store and as a GitHub release. Hope it works and thanks for all your help!

Thanks for finishing up the PR!