search

martin-marek / hdr-plus-swift

📸Night mode on any camera. Based on HDR+.
https://burst.photo
GNU General Public License v3.0
208 stars 11 forks source link

Seg Fault when merging iPhone 13 ProRaw Files #7

Closed Alex-Vasile closed 1 year ago

Alex-Vasile commented 1 year ago

To test things out I shot some ProRaw files with my iPhone 13 pro. I let it enable it automatic night mode. The resulting raw files (3 of them) that I shot sequentially I transfer to my Mac. When I drag them into Burst Photo the app immediately crashes. If I launch it from the terminal to try to get some better info into what's going on all I am told is "segmentation fault". This is with the version 1.1 (14). The version I have in #6 does not crash.

martin-marek commented 1 year ago

Thanks for reporting this. By any chance, did you mean ProRaw (instead of ProRes)? I was able to replicate this with ProRaw on iPhone 13 Pro. The issue is that ProRaw DNG files are already demoisaced but Burst Photo only supports mosaiced raw images.

Version 1.0 was not supposed to work with these images – the output will be unusable. Version 1.1 on the other hand is not supposed to crash. I fixed this issue (for now) by printing an error message when ProRaw files are used.

Alex-Vasile commented 1 year ago

Thanks for reporting this. By any chance, did you mean ProRaw (instead of ProRes)? I was able to replicate this with ProRaw on iPhone 13 Pro. The issue is that ProRaw DNG files are already demoisaced but Burst Photo only supports mosaiced raw images.

Version 1.0 was not supposed to work with these images – the output will be unusable. Version 1.1 on the other hand is not supposed to crash. I fixed this issue (for now) by printing an error message when ProRaw files are used.

Yup. ProRaw, my bad. I did mean to talk about still raws, not video.