martin-olivier / dylib

C++ cross-platform wrapper around dynamic loading of shared libraries (dll, so, dylib)
https://conan.io/center/recipes/dylib
MIT License
293 stars 44 forks source link

fix(mingw): fix build prefix of mingw shared libraries #63

Closed rmaxi-me closed 2 years ago

rmaxi-me commented 2 years ago

Fixes #62

Description

Fixed build with MinGW by changing shared library prefix back to Windows' default.

Changes include

Checklist

codecov[bot] commented 2 years ago

Codecov Report

Merging #63 (84c45b2) into main (f951429) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 84c45b2 differs from pull request most recent head e5a741c. Consider uploading reports for the commit e5a741c to get more accurate results

@@            Coverage Diff            @@
##              main       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           59        59           
  Branches         3         3           
=========================================
  Hits            59        59           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rmaxi-me commented 2 years ago

As last time, can't assign myself or a reviewer on this 😛

martin-olivier commented 2 years ago

Thank you, The issue has been fixed on this pull request: https://github.com/martin-olivier/dylib/pull/64