martin-olivier / dylib

C++ cross-platform wrapper around dynamic loading of shared libraries (dll, so, dylib)
https://conan.io/center/recipes/dylib
MIT License
293 stars 44 forks source link

Allow disabling use of <filesystem> on C++17 #66

Closed SadieCat closed 1 year ago

SadieCat commented 2 years ago

Description

Please provide a detailed description of what was done in this PR.

Changes include

Checklist

Additional comments

<filesystem> is quite a big header. On my system echo '#include <filesystem>' | c++ -E -x c++ - | wc -l shows that it is 50K lines of code. Including such a large header unnecessarily in projects with a lot of translation units can affect build times quite significantly. Therefore, I added an escape hatch that allows such projects to opt-out of std::filesystem support if they don't need it.

codecov[bot] commented 2 years ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (718b571) compared to base (eb3acad). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #66 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 59 55 -4 Branches 3 3 ========================================= - Hits 59 55 -4 ``` | [Impacted Files](https://codecov.io/gh/martin-olivier/dylib/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martin+Olivier) | Coverage Δ | | |---|---|---| | [include/dylib.hpp](https://codecov.io/gh/martin-olivier/dylib/pull/66/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martin+Olivier#diff-aW5jbHVkZS9keWxpYi5ocHA=) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martin+Olivier). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martin+Olivier)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.