martin-olivier / dylib

C++ cross-platform wrapper around dynamic loading of shared libraries (dll, so, dylib)
https://conan.io/center/recipes/dylib
MIT License
293 stars 44 forks source link

Define NOMINMAX when including Windows.h #81

Closed DolphyWind closed 7 months ago

DolphyWind commented 7 months ago

Description

Hi, really nice library. I've recently got into an issue while using this library with std::numeric_limits<T>::min() and std::numeric_limits<T>::max() and it turned out those pesky evil min and max macros from Windows.h were the issue. This is a small pr that fixes it.

Changes include

Checklist

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d848a2f) 100.00% compared to head (80d6be0) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #81 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 57 57 Branches 3 3 ========================================= Hits 57 57 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

martin-olivier commented 7 months ago

Hello @DolphyWind,

Thank you for your pull request.

BR