Closed DaneWeber closed 7 years ago
@Fluffums Hmm... I will investigate in that issue, as soon as my time permits. But from a quick view, it doesn't surprise me that viewing a J notebook from within github does not work. On github there is no J infrastructure (as far as I know). So there is also no J kernel for jupyter notebook. The server part (when you start "jupyter notebook" on your local machine) includes all the needed J stuff. Not so on github. Please tell me if I'm wrong. How ever ... I will take a look at it.
Displaying a notebook in GitHub should not involve running any code, and thus shouldn't involve a kernel, J or otherwise. If you look at the code in a Jupyter notebook, it includes all output, so which is what should be displayed.
Here a couple other working examples of languages where I'd doubt that GitHub is doing anything other than formatting the .ipynb
for display:
iTorch: https://github.com/facebook/iTorch/blob/master/iTorch_Demo.ipynb
OCaml: https://github.com/andrewray/iocaml/blob/master/notebooks/iocaml-the-core-language.ipynb
But then here's a failing example of Q+KDB: https://github.com/jvictorchen/IKdbQ/blob/master/examples/QforMortals2_tables.ipynb
Interestingly, the Jupyter nbviewer site handles the J notebooks just fine, so this really might be entirely on GitHub's side. http://nbviewer.jupyter.org/github/fluffums/MixerRepulsionMotes/blob/master/Simple%20J%20Notebook.ipynb
nbviewer's repo: https://github.com/jupyter/nbviewer
I wonder where GitHub's notebook viewer comes from, or if they're running an old broken version of Jupyter's nbviewer.
I just opened an issue with nbviewer: https://github.com/jupyter/nbviewer/issues/644
No follow up, but the notebooks are working in GitHub now, so that's good.
GitHub chokes on notebooks with this kernel. Any ideas on the cause?
While it applies to my notebooks (I tested a notebook that has only a single markdown cell and no code), you can see the problem by trying to view of the example notebooks in this repo: https://github.com/martin-saurer/jkernel/blob/master/examples/Rain_Temperature.ipynb
GitHub will work for awhile and then display, "Sorry, something went wrong. Reload?"
Also compare the following https://github.com/Fluffums/MixerRepulsionMotes/blob/master/Simple%20Python%20Notebook.ipynb https://github.com/Fluffums/MixerRepulsionMotes/blob/master/Simple%20J%20Notebook.ipynb
This last notebook in particular, when I view the raw files, I notice that the Python notebook has some metadata missing from the J notebook.
Python:
vs. J: