search

martin-stone / hsv-alpha-color-picker-android

A color picker and a color preference for use in Android applications.
Apache License 2.0
290 stars 60 forks source link

Add option for hiding the swatchView #32

Closed JulianEggers closed 7 years ago

JulianEggers commented 7 years ago

Hi Martin, I really like your color picker and would like to use it for two little projects that I am currently working on. However, the color picker would fit much better into my apps without the swatchView. That is why I created this pull request that hopefully implements the complete functionality + readme documentation to hide the swatchView.

I hope this functionality is fine for you. -- Julian

martin-stone commented 7 years ago

Looks great! Just one tiny oversight: The ColorPreference class doesn't do anything with the showPreview variable that you set -- Just needs a picker.showPreview(showPreview); in onPrepareDialogBuilder(). Will gladly merge it once added.

JulianEggers commented 7 years ago

Added the missing line. Thank you in advance. :)

martin-stone commented 7 years ago

Great stuff -- Merged!

I'll get a version up onto jcenter shortly.

martin-stone commented 7 years ago

It's now up on jcenter, version 2.2.0.

Thanks!