search

martin-stone / hsv-alpha-color-picker-android

A color picker and a color preference for use in Android applications.
Apache License 2.0
290 stars 60 forks source link

Remove padding of color picker layout #33

Closed JulianEggers closed 1 year ago

JulianEggers commented 7 years ago

Hello again, I ran into the problem that the complete color picker has a padding of 16dp that must be considered when aligning other views with the color picker.

Therefor, I thought about removing the padding. Thus, the users of this library could decide for themselves about the margin.

Hope you like this modification. --Julian

martin-stone commented 7 years ago

Hi Julian.

Unfortunately, this makes the ColorPreference dialog look a bit odd. I recognise the advantage, but there needs to be a compensating padding on the dialog instead. I'm sure it's possible, but I don't know what the neatest way to do it is. Maybe you could investigate?

JulianEggers commented 7 years ago

Currently I don't have enough time but will try to solve that. I'll let you know when I have more information.

JulianEggers commented 1 year ago

Closing as too old and not required anymore.